feat: single character wildcard matching #437
Conversation
| return matches(s, true); | ||
| } | ||
|
|
||
| public boolean matches(String s, boolean matchSingleCharWildcard) { |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
The cyclomatic complexity of this method is 21. By comparison, 99% of the methods in the CodeGuru reference dataset have a lower cyclomatic complexity. This indicates the method has a high number of decisions and it can make the logic difficult to understand and test.
We recommend that you simplify this method or break it into multiple methods. For example, consider extracting the code block on lines 123-132 into a separate method.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -48,23 +50,19 @@ | |||
| * | | |||
| * </p> | |||
| */ | |||
| @Builder | |||
Check notice
Code scanning / CodeQL
Use of default toString() Note
| } | ||
|
|
||
| @SuppressFBWarnings("EQ_DOESNT_OVERRIDE_EQUALS") | ||
| private static class DefaultHashMap<K, V> extends HashMap<K, V> { |
Check failure
Code scanning / CodeQL
No clone method Error
Benchmark Results
|
| } | ||
| } | ||
|
|
||
| private class Node { |
Check notice
Code scanning / CodeQL
Inner class could be static Note
| return matches(root, s); | ||
| } | ||
|
|
||
| private boolean matches(@NonNull Node n, @NonNull String s) { |
There was a problem hiding this comment.
Recommendation generated by Amazon CodeGuru Reviewer. Leave feedback on this recommendation by replying to the comment or by reacting to the comment using emoji.
The cyclomatic complexity of this method is 17. By comparison, 99% of the methods in the CodeGuru reference dataset have a lower cyclomatic complexity. This indicates the method has a high number of decisions and it can make the logic difficult to understand and test. We recommend that you simplify this method or break it into multiple methods.
| operations: | ||
| - "mqtt:subscribe" | ||
| resources: | ||
| - "mqtt:topic:${iot:Connection.Thing.ThingName}/???/test/*" |
There was a problem hiding this comment.
Are the combination of single level ? and multi level * valid in the same level and should we test for it? Ex: mqtt:topic:myThing/???* or mqtt:topic:myThing/*???
There was a problem hiding this comment.
Evaluation here is more regex-like than mqtt: * doesn't know anything about topic levels.
There should be test cases for this in WildcardTrieTest already (not all are passing quite yet)
Issue #, if available:
Description of changes:
Adds new configuration option
enableSingleCharacterWildcardMatchingto allow?matching in CDA policy resources.?will match any single character, similar to how IoT Core handles it (https://docs.aws.amazon.com/iot/latest/developerguide/pub-sub-policy.html#pub-sub-policy-cert). Reason for flag is to ensure CDA version upgrade doesn't make policies already containing a?more permissive than originally intended.Why is this change necessary:
To maintain feature parity with IoT Core
How was this change tested:
Unit and integration tests
Any additional information or context required to review the change:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.